Open
Conversation
Cover previously-untested branches: shouldGenerateStructures, shouldGenerateMobs, and BiomeProvider.getBiomes across all three environments. Verify the IslandAboutCommand return value and the two license lines that weren't asserted. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Main: - BSkyBlock: drop unused WorldType import; extract applySpawnLimits to reduce getWorld cognitive complexity. - Settings: mark deprecated flag/setting maps with @deprecated (forRemoval) to match the parent interface. - ChunkGeneratorWorld: replace nested ternaries with a switch-based defaultBiomeFor helper; split makeNetherRoof into smaller methods (fillRoofColumn, placeGlowstoneBlob and friends) to drop its cognitive complexity well under the threshold. Tests: - Drop JUnit 5 public modifiers across SettingsTest, BSkyBlockTest, ChunkGeneratorWorldTest, and IslandAboutCommandTest. - IslandAboutCommandTest: remove useless eq(...) matchers. - CommonTestSetup: replace deprecated FixedMetadataValue with a mock, delete commented-out lines, and suppress unavoidable deprecation warnings around PlayerDeathEvent. - TestWorldSettings: silence removal warnings on the deprecated WorldSettings overrides. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…E.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
There was a problem hiding this comment.
Pull request overview
Updates BSkyBlock for the 1.20.0 release by aligning generator behavior and tests with newer Paper/Bukkit APIs, refreshing locale formatting, and tightening up test code warnings/visibility.
Changes:
- Migrates
ChunkGeneratorWorldto newer generation hooks (generateNoise,getDefaultBiomeProvider, updatedshouldGenerateStructuressignature) and refactors nether-roof generation helpers. - Updates multiple locale sign lines from legacy
&cformatting to<red>…</red>-style tags. - Modernizes/cleans up tests (JUnit 5 visibility, deprecation/removal suppressions, updated generator tests) and updates the about/copyright output.
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/world/bentobox/bskyblock/TestWorldSettings.java | Suppresses removal warnings for deprecated API-compat methods in tests. |
| src/test/java/world/bentobox/bskyblock/SettingsTest.java | Makes JUnit 5 test class/methods package-private. |
| src/test/java/world/bentobox/bskyblock/generators/ChunkGeneratorWorldTest.java | Updates generator tests to generateNoise/BiomeProvider API and adds coverage for new hooks. |
| src/test/java/world/bentobox/bskyblock/CommonTestSetup.java | Adjusts test scaffolding (Sonar suppressions, metadata mocking). |
| src/test/java/world/bentobox/bskyblock/commands/IslandAboutCommandTest.java | Updates assertions for new about output and validates return value. |
| src/test/java/world/bentobox/bskyblock/BSkyBlockTest.java | Makes JUnit 5 test class package-private. |
| src/main/resources/locales/zh-TW.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/zh-CN.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/vi.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/tr.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/ru.yml | Updates RU sign text and formatting tags. |
| src/main/resources/locales/ro.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/pt.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/pl.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/nl.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/lv.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/ko.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/ja.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/it.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/id.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/hu.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/fr.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/es.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/en-US.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/de.yml | Updates sign color formatting to <red>…</red>. |
| src/main/resources/locales/cs.yml | Updates sign line3 formatting. |
| src/main/resources/addon.yml | Bumps declared BentoBox addon api-version. |
| src/main/java/world/bentobox/bskyblock/Settings.java | Improves deprecation metadata/docs for API compatibility methods. |
| src/main/java/world/bentobox/bskyblock/generators/ChunkGeneratorWorld.java | Migrates generator implementation to modern APIs; refactors nether-roof logic. |
| src/main/java/world/bentobox/bskyblock/commands/IslandAboutCommand.java | Updates about/copyright line output. |
| src/main/java/world/bentobox/bskyblock/BSkyBlock.java | Extracts spawn-limit application to a helper method. |
| CLAUDE.md | Adds dependency source lookup/project layout documentation for contributors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (x > 3 && z > 3) { | ||
| for (int xx = 0; xx < 3; xx++) { | ||
| for (int zz = 0; zz < 3; zz++) { | ||
| setBlock(x - xx, -8 - rand.nextInt(2), z - xx, Material.GLOWSTONE); |
There was a problem hiding this comment.
In placeGlowstonePatch, the Z coordinate uses z - xx inside the inner zz loop. This makes the patch generation incorrect (Z offset mirrors X offset) and likely produces a diagonal line instead of a 3x3 patch. Use z - zz for the Z offset so both loop indices are applied correctly.
Suggested change
| setBlock(x - xx, -8 - rand.nextInt(2), z - xx, Material.GLOWSTONE); | |
| setBlock(x - xx, -8 - rand.nextInt(2), z - zz, Material.GLOWSTONE); |
Comment on lines
+8
to
+11
| line0: '<red>BSkyBlock' | ||
| line1: Приветствуем! | ||
| line2: '[name]' | ||
| line3: Не падай! <red><3 |
There was a problem hiding this comment.
line0 and line3 use <red> but (unlike the other locales updated in this PR) they don't include a matching </red> close tag. Please make the formatting consistent (e.g., <red>…</red>) to avoid issues with whatever component/markup parser is used for sign text.
Suggested change
| line0: '<red>BSkyBlock' | |
| line1: Приветствуем! | |
| line2: '[name]' | |
| line3: Не падай! <red><3 | |
| line0: '<red>BSkyBlock</red>' | |
| line1: Приветствуем! | |
| line2: '[name]' | |
| line3: Не падай! <red><3</red> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.