Taking EVSE chargepoints off of Meters category by refactoring getFactoriesByNature to support multiple exclusions#3672
Open
janklostermann wants to merge 1 commit intoOpenEMS:developfrom
Conversation
…king EVSE of of Meters To avoid EVSE chargepoints ending up in the Meters category, this fix allows more then one exclusion per category, now allowing a list. It is used to enhance the CATEGORY.TITLE.METER with not only excluding evcs.api.Evcs, but also evse.api.chargepoint.EvseChargePoint.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3672 +/- ##
=============================================
+ Coverage 60.13% 62.35% +2.23%
Complexity 104 104
=============================================
Files 3209 2901 -308
Lines 141232 132138 -9094
Branches 10402 8868 -1534
=============================================
- Hits 84910 82382 -2528
+ Misses 53157 46731 -6426
+ Partials 3165 3025 -140 🚀 New features to boost your workflow:
|
Contributor
Author
|
Can someone please help me with this linter issue in the CI? If I run the sequence locally: "All files pass linting." Beyond that: It complains that Therefore: How can I make this PR acceptable and let it pass the linter? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid EVSE chargepoints ending up in the Meters category, this fix allows more then one exclusion per category, now allowing a list. It is used to enhance the CATEGORY.TITLE.METER with not only excluding evcs.api.Evcs, but also evse.api.chargepoint.EvseChargePoint.