Merged
Conversation
berryr0
commented
Jul 7, 2025
berryr0
commented
Jul 7, 2025
berryr0
commented
Jul 7, 2025
berryr0
commented
Jul 7, 2025
| ] | ||
| }, | ||
| resolve: { | ||
| // make sure we get the same libraries even if we symlink in dependencies |
Contributor
Author
There was a problem hiding this comment.
I removed this because it was causing errors when running dev for me. It was causing dev to keep looking at incorrect dependency after the version was upgraded.
berryr0
commented
Jul 7, 2025
| icon: () => { | ||
| const [attachments] = useContext(MultipartAttachmentsInternalContext); | ||
| const pluginContext = usePluginContext(); | ||
| const visiblePlugin = useGraphiQL(state => state.visiblePlugin); |
Contributor
Author
There was a problem hiding this comment.
useGraphiQL is now responsible for the following things:
https://github.com/graphql/graphiql/blob/main/packages/graphiql-react/README.md#available-stores
berryr0
commented
Jul 7, 2025
neeraj-aduri-wday
approved these changes
Jul 10, 2025
neeraj-aduri-wday
left a comment
neeraj-aduri-wday
left a comment
There was a problem hiding this comment.
Nice work. Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Upgraded graphiql and graphiql react
🔍 Changes Made
🧪 Testing
Describe how you tested the changes and any edge cases considered.
📷 Screenshots (if UI-related)
✅ Checklist
Please confirm all items are complete before requesting a review:
lintand fixed any issues