fix(auth0-fastify-api): Use 401 instead of 400 when no access token provided#11
Draft
frederikprijck wants to merge 4 commits intomainfrom
Draft
fix(auth0-fastify-api): Use 401 instead of 400 when no access token provided#11frederikprijck wants to merge 4 commits intomainfrom
frederikprijck wants to merge 4 commits intomainfrom
Conversation
panva
reviewed
Apr 14, 2025
| ommitHeaderDetails = false | ||
| ) => { | ||
| const headerValue = ommitHeaderDetails | ||
| ? `Bearer` |
Member
There was a problem hiding this comment.
We actually have to have an auth-param component here in order for the www-authenticate to be valid as per its definition.
This can the form of WWW-Authenticate: Bearer realm="${currentUrlOrSomeArbitraryIdentifier}"
|
Is this still planned? I started using this plugin today, and was surprised to get a 400 back rather than a 401 when no auth headers were sent. Would be great to see this change in a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to return as 401, instead of a 400 in the case where the request has no authorization header.
When there is a malformed authorization header, we still return a 400.