Open
Conversation
Adds optional `headers` field to `ModelConfigParam`, allowing users to pass custom HTTP headers with every request to their model provider. This aligns the Python SDK with the core TypeScript SDK which already supports `headers` on `ClientOptions` and `ModelConfigObjectSchema`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
headers: Dict[str, str]field toModelConfigParamin the Python SDKact,extract,observe,execute)headerson bothClientOptionsandModelConfigObjectSchemaContext
The TypeScript core supports custom headers on LLM requests —
ClientOptionsinmodel.tshasheaders?: Record<string, string>, andModelConfigObjectSchemainapi.tshasheaders: z.record(z.string(), z.string()).optional(). The Python SDK'sModelConfigParamwas missing this field, preventing users who route LLM calls through a proxy (viabaseURL) from passing required auth headers.What was tested
baseURL+apiKeyonModelConfigParamworks end-to-end —act()andextract()both succeededpackages/server) and testedact()withheadersin model config — confirmed headers flow throughresolveLlmClient()→getClient()→getAISDKLanguageModel()→createOpenAI(clientOptions), where@ai-sdk/openainatively acceptsheadersresolveLlmClient()→LLMProvider.getAISDKLanguageModel()→ AI SDK provider creation. The...restspread inresolveLlmClient()passes allClientOptionsfields (includingheaders) directly through to the provider creatorUsage
Works on
act(),extract(),observe(), andexecute()— all param types importModelConfigParam.Test plan
headersfield is accepted without error onact(),extract(),observe(),execute()headerscontinues to work as before🤖 Generated with Claude Code