Draft
Conversation
Signed-off-by: Ives van Hoorne <ives@codesandbox.io> update test Co-authored-by: Luminita Voicu <lumivo@amazon.com> move test to valid headers
This allows us to run VMs while streaming memory changes to disk support mmap shared update log add configuration for memory backing file Progress tweaks
Firecracker used to map over the mmap when it was a restore. For CodeSandbox this is not needed, as we use UFFD and we don't have the limitation that the map was used for. In fact, this is problematic for the UFFD handler, because it implicitly unregisters the UFFD handler from the reclaimed range.
Firecracker is taking significant time on saving the snapshot file. For comparison: writing the memory snapshot by us (1GiB) takes 1s, and writing the snapshot file by Firecracker (150KiB) takes 8.5s. We presume this is because of the syncing of the metadata, which is why we disable it for now. The filesystem should still handle persisting, and given the fact that the snapshot/memory files are temporary anyway, we can afford to not sync/flush.
CompuIves
force-pushed
the
uffd-superbranch
branch
from
b8f3073 to
e9dda44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.