fix: issue with eslint rule for notification

[nmerget]

Proposed changes

fix: issue with eslint rule for notification. close-button-text-required rule now only requires closeButtonText when closeable attribute is set.

Types of changes

• Bugfix (non-breaking change that fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (improvements to existing components or architectural decisions)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-eslint-notification-closeable

[changeset-bot]

🦋 Changeset detected

Latest commit: 0355066

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@db-ux/core-eslint-plugin	Patch
@db-ux/core-foundations	Patch
@db-ux/core-components	Patch
@db-ux/react-core-components	Patch
@db-ux/ngx-core-components	Patch
@db-ux/v-core-components	Patch
@db-ux/wc-core-components	Patch
@db-ux/core-stylelint	Patch
@db-ux/core-migration	Patch
@db-ux/agent-cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Copilot]

Pull request overview

This PR fixes an ESLint rule (close-button-text-required) in the custom ESLint plugin so that DBNotification only requires the closeButtonText attribute when the closeable attribute is explicitly set. Previously, the rule required closeButtonText even when closeable was absent (i.e., the close button was not shown), generating false-positive accessibility lint errors.

Changes:

• Updated the ESLint rule implementation to gate the closeButtonText requirement on the presence of the closeable attribute for DBNotification, handling Angular, React, and Vue ASTs separately.
• Updated test fixtures (Angular HTML, React TSX, Vue SFC) and the snapshot file to reflect the new rule behavior, and updated the unit test spec with the corrected valid/invalid cases.
• Changed dependencies version specifiers in package.json from pinned versions to >= open-ended ranges, and updated the lockfile accordingly.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/eslint-plugin/src/rules/close-button/close-button-text-required.ts	Core rule logic: adds closeable attribute presence checks for all three framework AST paths before enforcing closeButtonText
packages/eslint-plugin/test/rules/close-button/close-button-text-required.spec.ts	Updated unit tests: reflects that <DBNotification> without closeable is valid; <DBNotification closeable> without closeButtonText is invalid
packages/eslint-plugin/test/frameworks/angular-test.html	Updated integration test fixture to use two notification variants
packages/eslint-plugin/test/frameworks/react-test.tsx	Updated integration test fixture to use two notification variants
packages/eslint-plugin/test/frameworks/vue-test.vue	Updated integration test fixture to use two notification variants
packages/eslint-plugin/test/frameworks/__snapshots__/frameworks.spec.ts.snap	Updated snapshot: adjusted line numbers, endColumn, and removed incorrect missingContent errors
packages/eslint-plugin/package.json	Changed dependencies version specifiers from pinned to >= open-ended ranges; also updated peerDependencies for eslint
package-lock.json	Reflects the dependency version specifier changes and minor fsevents/esbuild lockfile updates
.changeset/fix-notification-closeable-eslint.md	Adds a changeset entry for the patch fix

Comments suppressed due to low confidence (1)

packages/eslint-plugin/test/rules/close-button/close-button-text-required.spec.ts:74

• There are no unit tests covering the closeable={false} (React) or :closeable="false" / :closeable="true" (Vue) edge cases. The spec file only tests the plain closeable (truthy) attribute case but not the bound closeable={false} case for React or the :closeable="false" and plain closeable (non-bound) attribute for Vue. Since these are specifically mentioned in inline comments in the rule implementation, they should be verified with explicit test cases to confirm the rule correctly ignores <DBNotification closeable={false}> without closeButtonText (React) and <DBNotification :closeable="false"> (Vue).

	it('should validate rule', () => {
		ruleTester.run('close-button-text-required', rule, {
			valid: [
				{
					code: '<DBNotification closeable closeButtonText="Close">Message</DBNotification>'
				},
				{
					code: '<DBNotification>Message</DBNotification>'
				},
				{
					code: '<DBDrawer closeButtonText="Close drawer">Content</DBDrawer>'
				},
				{
					code: '<DBCustomSelect mobileCloseButtonText="Close" label="Select" />'
				},
				{
					code: '<DBCustomSelect :mobileCloseButtonText="closeText" label="Select" />'
				}
			],
			invalid: [
				{
					code: '<DBNotification closeable>Message</DBNotification>',
					errors: [
						{
							messageId: 'missingCloseButtonText',
							data: {
								component: 'DBNotification',
								attribute: 'closeButtonText'
							}
						}
					]
				},
				{
					code: '<DBDrawer>Content</DBDrawer>',
					errors: [
						{
							messageId: 'missingCloseButtonText',
							data: {
								component: 'DBDrawer',
								attribute: 'closeButtonText'
							}
						}
					]
				},
				{
					code: '<DBCustomSelect label="Select" />',
					errors: [
						{
							messageId: 'missingCloseButtonText',
							data: {
								component: 'DBCustomSelect',
								attribute: 'mobileCloseButtonText'
							}
						}
					]
				}
			]
		});