feat(mcp-server): add agentic code verification loop to migrate tool#6468
Open
michaelmkraus wants to merge 8 commits intomainfrom
Open
feat(mcp-server): add agentic code verification loop to migrate tool#6468michaelmkraus wants to merge 8 commits intomainfrom
michaelmkraus wants to merge 8 commits intomainfrom
Conversation
|
…nt ReDoS
Replace regex patterns in wrapCode() with simple String.includes() checks
to resolve CodeQL 'Polynomial regular expression used on uncontrolled data'
finding. The previous patterns /import\s+React[\s,{]/ and
/import\s*{[^}]*Component[^}]*}\s*from\s*['"]@angular\/core['"]/ had
overlapping quantifiers that could cause exponential backtracking on
crafted input. String.includes() provides O(n) worst-case and is
semantically sufficient for detecting existing imports.
…into feat-mcp-agentic-feedback-loop
…into feat-mcp-agentic-feedback-loop
…into feat-mcp-agentic-feedback-loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR upgrades the migration engine. The AI is now forced to locally compile its generated code, analyze errors, and self-correct before outputting the final result.
Key Changes
Added
verify_migrated_codeto run framework-specific compiler checks (e.g.,tsc --noEmit) via secure, hidden temp files.Agentic Workflow: Updated the
migrate.tsprompt to enforce a mandatory verification loop with a maximum of 3 retries.Maintenance: Updated
README.md,CONTEXT.md, and agent instructions, plus added new integration tests.Types of changes
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/feat-mcp-agentic-feedback-loop