Open
Conversation
The rebuilder has been using the hard-coded `process.platform` value as the platform attribute all this time. This means, no matter what platform option you pass in, it would just use the current OS platform. Basically, cross platform prebuild has not been working at all. Combined with the electron-builder fix here cocktailpeanut/electron-builder@73f751b - now you can do cross platform electron builds that include prebuilt binaries.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
=======================================
Coverage 76.44% 76.44%
=======================================
Files 19 19
Lines 692 692
Branches 134 135 +1
=======================================
Hits 529 529
Misses 118 118
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarshallOfSound
requested changes
Apr 12, 2023
Member
MarshallOfSound
left a comment
MarshallOfSound
left a comment
There was a problem hiding this comment.
I think this is valid for prebuild modules but is invalid for modules powered via node-gyp. There should probably be checks in place to ensure that non-system-platform builds aren't even attempted for node-gyp builds
|
Looks like this was resolved in #1153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rebuilder has been using the hard-coded
process.platformvalue as the platform attribute all this time.This means, no matter what platform option you pass in, it would just use the current OS platform.
Basically, cross platform prebuild has not been working at all.
Combined with the electron-builder fix here cocktailpeanut/electron-builder@73f751b - now you can do cross platform electron builds that include prebuilt binaries.