Upgrade App to Rails 7.2 and dual boot Rails 8.0 #355
Open
etagwerker wants to merge 1 commit intomainfrom
Open
Upgrade App to Rails 7.2 and dual boot Rails 8.0 #355etagwerker wants to merge 1 commit intomainfrom
etagwerker wants to merge 1 commit intomainfrom
Conversation
- Update Rails from 7.1 to 7.2 as current version - Set up dual-boot targeting Rails 8.0 (all 204 tests pass on both) - Update load_defaults from 7.1 to 7.2 - Update rspec-rails ~> 6.1 (fixture_paths support) - Update database_cleaner-active_record to 2.2.2 (Rails 7.2 compat) - Fix show_exceptions: false → :none in test.rb - Fix fixture_path → fixture_paths in rails_helper.rb - Remove config.read_encrypted_secrets from production.rb - Opt in to Rails 8.1 to_time_preserves_timezone = :zone Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Upgrades the application’s primary Rails version to 7.2 while maintaining a dual-boot setup for Rails 8.0, along with supporting configuration and dependency updates needed for compatibility.
Changes:
- Bump Rails defaults/configuration to 7.2 and adjust environment settings for Rails 7.2 behavior.
- Update test/support configuration to match newer rails/rspec-rails APIs (fixtures, exception handling).
- Refresh dependencies and lockfiles for Rails 7.2 (main) and Rails 8.0 (next/dual-boot).
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/rails_helper.rb | Updates fixtures configuration to fixture_paths for newer rspec-rails compatibility. |
| config/environments/test.rb | Updates exception handling setting to Rails 7.2-supported value (:none). |
| config/environments/production.rb | Removes deprecated encrypted secrets loading config and clarifies secret key base sourcing. |
| config/application.rb | Advances load_defaults to 7.2 and opts into to_time timezone preservation behavior. |
| Gemfile | Sets Rails 7.2 as default and Rails 8.0 under dual-boot; bumps rspec-rails requirement. |
| Gemfile.lock | Updates resolved dependencies for Rails 7.2 and related gems. |
| Gemfile.next.lock | Updates resolved dependencies for Rails 8.0 dual-boot bundle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Here are the changes in this PR:
Jira Ticket
N/A
Motivation / Context
Testing Claude Code Upgrade Skill by FastRuby.io + OmbuLabs.ai
QA / Testing Instructions
Staging should work.
Test suite should pass for both Rails versions
Screenshots:
N/A
✅ I will abide by the code of conduct.