docs: community image & license updates#502
Conversation
quetzalliwrites
requested review from
HarshCasper,
anisaoshafi,
bentsku,
cloutierMat,
dfangl,
dominikschubert,
giograno,
hovaesco,
joe4dev,
k-a-il,
macnev2013,
pinzon,
remotesynth,
silv-io,
simonrw,
thrau and
viren-nadkarni
as code owners
Deploying localstack-docs with
|
| Latest commit: |
977398e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://54ac7c44.localstack-docs.pages.dev |
| Branch Preview URL: | https://docs-oss-img-updates.localstack-docs.pages.dev |
src/content/docs/aws/capabilities/config/initialization-hooks.mdx
Outdated
Show resolved
Hide resolved
remotesynth
left a comment
remotesynth
left a comment
There was a problem hiding this comment.
Mostly minor tweaks and corrections
src/content/docs/aws/capabilities/config/initialization-hooks.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/aws/tutorials/reproducible-machine-learning-cloud-pods.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: agjonca <alexa.gjonca@localstack.cloud>
|
@cloutierMat @agjonca hola folks, this is ready for review again! |
Co-authored-by: agjonca <alexa.gjonca@localstack.cloud>
Co-authored-by: agjonca <alexa.gjonca@localstack.cloud>
Co-authored-by: agjonca <alexa.gjonca@localstack.cloud>
Co-authored-by: agjonca <alexa.gjonca@localstack.cloud>
Co-authored-by: agjonca <alexa.gjonca@localstack.cloud>
agjonca
left a comment
agjonca
left a comment
There was a problem hiding this comment.
changes made to app inspector line in new plan comparison table & legacy plan comparison table
Co-authored-by: agjonca <alexa.gjonca@localstack.cloud>
cloutierMat
left a comment
cloutierMat
left a comment
There was a problem hiding this comment.
Thanks for the quick follow up!
joe4dev
left a comment
joe4dev
left a comment
There was a problem hiding this comment.
Lambda lgtm
❓ Are we updating the API coverage section to remove the image column?
tyvm @joe4dev for calling that out, let me sync w/ @remotesynth when he starts his day :) |
| | `DEBUG` | `0` (default) \|`1`| Flag to increase log level and print more verbose logs (useful for troubleshooting issues)| | ||
| | `IMAGE_NAME`| `localstack/localstack` (default), `localstack/localstack:0.11.0` | Specific name and tag of LocalStack Docker image to use.| | ||
| | `GATEWAY_LISTEN`| `0.0.0.0:4566` (default in Docker mode) `127.0.0.1:4566` (default in host mode) | Configures the bind addresses of LocalStack. It has the form `<ip address>:<port>(,<ip address>:<port>)*`. LocalStack Pro adds port `443`. | | ||
| | `GATEWAY_LISTEN`| `0.0.0.0:4566` (default in Docker mode) `127.0.0.1:4566` (default in host mode) | Configures the bind addresses of LocalStack. It has the form `<ip address>:<port>(,<ip address>:<port>)*`. LocalStack for AWS adds port `443`. | |
There was a problem hiding this comment.
nit: I think we don't allow host mode any more. Should this be simplified ?
There was a problem hiding this comment.
If you can confirm it, then we can update this. @nik-localstack i will await your confirmation :)
There was a problem hiding this comment.
Yes this shouldn't be mentioned in the docs. I confirmed with @alexrashed
| organization. | ||
| In other words, any public Cloud Pod can be injected by any | ||
| other user holding a LocalStack Pro (or above) license. | ||
| other user holding a LocalStack for AWS (or above) license. |
There was a problem hiding this comment.
What (or above) means here ? Is LocalStack for AWS a license type or a product name ?
| method: ANY | ||
| cors: true | ||
| # Please, note that events are a LocalStack PRO feature | ||
| # Please, note that events are a LocalStack for AWS feature |
There was a problem hiding this comment.
This comment doesn't make sense anymore. Shouldn't it say that the events are supported in a specific License ?
There was a problem hiding this comment.
I think the usage of Pro in this file gives the extra info that some of these features are not included in the free tier. With these changes this is not clear any more.
| ## DNS resolution | ||
|
|
||
| LocalStack Pro supports the ability to respond to DNS queries for your Route53 domain names, with our [integrated DNS server](/aws/tooling/dns-server). | ||
| LocalStack for AWS supports the ability to respond to DNS queries for your Route53 domain names, with our [integrated DNS server](/aws/tooling/dns-server). |
There was a problem hiding this comment.
Pro here was hinting that this is not a free plan feature.
| ## SMTP Integration | ||
|
|
||
| LocalStack Pro supports sending emails via an SMTP server. | ||
| LocalStack for AWS supports sending emails via an SMTP server. |
There was a problem hiding this comment.
How do users know now that SMTP integration is not in the Free plan ?
| localstack: | ||
| container_name: "localstack-main" | ||
| image: localstack/localstack-pro # required for Pro | ||
| image: localstack/localstack |
There was a problem hiding this comment.
Should all usages of the localstack/localstack-pro be renamed, or this will be done later ?
There was a problem hiding this comment.
That should be done later, definitely OOO for this PR. The migration path for the previous weeks clearly was "use pro everywhere" and also at this point in time that's the most future-proof usage.
There was a problem hiding this comment.
Ok makes sense. I just had a call with @quetzalliwrites to discuss my previous comments and it was mentioned that this is something that we should change. So I pointed to the remaining items. I will resolve all my comments related to this point.
There was a problem hiding this comment.
So this change should be reverted then ?
There was a problem hiding this comment.
I think smiliar to this comment from @remotesynth it should be:
| image: localstack/localstack | |
| image: localstack/localstack-pro |
|
|
||
| [Lambda layers](https://docs.aws.amazon.com/lambda/latest/dg/configuration-layers.html) let you include additional code and dependencies in your Lambda functions. | ||
| With a valid LocalStack license, you can deploy Lambda Layers locally to streamline your development and testing process. | ||
| The Community image also allows creating, updating, and deleting Lambda Layers, but they are not applied when invoking a Lambda function. |
There was a problem hiding this comment.
❓ How do users know that Lambda layers are not supported in the Free/Hobby tier?
Unless we present this information somewhere else, I suggest rephrasing such limitations by mentioning the specific licensing tier (I guess that would be base here – please double-check).
Related comment (for another service): https://github.com/localstack/localstack-docs/pull/502/changes#r2965078162
There was a problem hiding this comment.
I understand your issue but licensing tiers are subject to frequent revisions. I don't think it's the job of documentation to call out all the specific entitlements of each tier. We do our best to provide that info on the licensing and tiers page and via tagging services but to include that throughout the content of each page will be a maintenance mess and likely to cause significant mistakes in the future.
There was a problem hiding this comment.
I understand the maintenance challenge.
Users might get frustrated if we don't explain them how licensing works for features split across tiers (especially for such a FAQ). Do we decide not to tell them or do we offer an alternative way of communication?
18 participants
Resolves: