Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the counterpart to the stix-validator change: oasis-open/cti-stix-validator#243
This changes the schema to allow both ISO 639-2 and RFC 5646 languages. I added this to the stix-validator for backwards compatibility, but since it requires a change to the schema, I think this needs some discussion and consideration.
RIght now the schema requires the 3 letter codes of ISO 639-2 which doesn't match STIX 2.1 CS03 but does match STIX 2.1 CS02. After this patch, it will accept both ISO 639-2 and RFC 5646. (RFC 5646 is required by STIX 2.1 CS03). So objects that adhere to either CS will be allowed through rather than only those that match the latest spec.
Open to suggestions here.