fix: Potential CancellationError swallowing#123
Merged
Conversation
simolus3
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Some of our SDK methods run certain operations which could throw exceptions. Any potential exceptions are wrapped in a PowerSyncException for better visibility in consumer code.
While investigating a potential watched query cancellation issue. I noticed in the debugger that our Swift Cancellation Errors were wrapped in a
.operationError. While our watched queries cancel the consuming task regardless of the error type, we should generally not wrapCancellationErrors.This rethrows cancellation errors in our
wrapPowerSyncExceptionwrapper.