fix(app-ext): add publicPath config setting#132
Open
daniel-fahl wants to merge 1 commit intoquasarframework:nextfrom
Open
fix(app-ext): add publicPath config setting#132daniel-fahl wants to merge 1 commit intoquasarframework:nextfrom
daniel-fahl wants to merge 1 commit intoquasarframework:nextfrom
Conversation
…s loaded from correct path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses discussion #122 and issue #123 by refactoring the global component registration to a factory function. This function passes the publicPath configuration value from the boot file to the component's render function. Consequently, the rendering is now correctly aligned with non-root
publicPathsetting inquasar.config.jsand also works when using vue router history mode. This should ensure correct rendering when the project is hosted in subdirectories, such as /some/nested/dir/.