Conversation
✅ Deploy Preview for docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request updates the Go module dependencies in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
blobl-editor/wasm/go.mod (1)
57-58: Awareness: protoreflect v2 beta dependency added.A new indirect dependency on
jhump/protoreflect/v2 v2.0.0-beta.2(line 58) has been added alongside the existing v1 (line 57). Since this is a beta version, it may introduce instability or breaking changes in future updates.Monitor this dependency in future updates and consider pinning to stable versions when v2 is officially released, or verify that the upstream packages (benthos/connect) are handling this appropriately.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@blobl-editor/wasm/go.mod` around lines 57 - 58, go.mod now includes an indirect beta dependency github.com/jhump/protoreflect/v2 v2.0.0-beta.2 alongside the stable v1 entry; to address this, verify whether the v2 entry originates from an upstream module (e.g., benthos/connect) and either update that upstream or explicitly pin the dependency to a stable version (remove or replace the v2 indirect requirement) to avoid pulling a beta into builds, and add a short comment in go.mod noting the reason for the pin/override so future reviewers see why github.com/jhump/protoreflect and github.com/jhump/protoreflect/v2 are present.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@blobl-editor/wasm/go.mod`:
- Line 3: go.mod requires Go 1.26.1 but the CI workflow still pins Go to 1.25.x
causing builds to fail; update the test workflow to install Go 1.26.x (or
'stable') by changing the actions/setup-go step's go-version to '1.26.x' and
update the cache key to use go-1.26.x (e.g., key: ${{ runner.os }}-go-1.26.x-${{
hashFiles('**/go.sum') }}); ensure the changes are applied in the
test-bloblang-playground workflow that currently uses actions/setup-go@v5 so CI
satisfies the go.mod requirement.
---
Nitpick comments:
In `@blobl-editor/wasm/go.mod`:
- Around line 57-58: go.mod now includes an indirect beta dependency
github.com/jhump/protoreflect/v2 v2.0.0-beta.2 alongside the stable v1 entry; to
address this, verify whether the v2 entry originates from an upstream module
(e.g., benthos/connect) and either update that upstream or explicitly pin the
dependency to a stable version (remove or replace the v2 indirect requirement)
to avoid pulling a beta into builds, and add a short comment in go.mod noting
the reason for the pin/override so future reviewers see why
github.com/jhump/protoreflect and github.com/jhump/protoreflect/v2 are present.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0c0dc5af-9575-4696-970a-64901984f2dd
⛔ Files ignored due to path filters (1)
blobl-editor/wasm/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
blobl-editor/wasm/go.mod
blobl-editor/wasm/go.mod
Outdated
| module blobl | ||
|
|
||
| go 1.25.6 | ||
| go 1.26.1 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Is Go 1.26.1 an officially released version? What is the latest stable Go version as of April 2026?
💡 Result:
Yes, Go 1.26.1 is an officially released version. It was released on 2026-03-05 as a minor revision of Go 1.26.0 (released 2026-02-10), including security and bug fixes. As of April 2026 (today 2026-04-02), the latest stable Go version is Go 1.26.1, available for download on the official site and listed as the top stable version.
Citations:
- 1: https://go.dev/doc/devel/release.html
- 2: https://go.dev/dl
- 3: https://go.dev/doc/devel/release
- 4: https://go.dev/dl/
- 5: https://www.reddit.com/r/golang/comments/1rm7vnq/go_1261_is_released/
🏁 Script executed:
# Find and inspect the test-bloblang-playground workflow file
find . -name "test-bloblang-playground.yml" -o -name "*bloblang*playground*.yml" 2>/dev/null | head -20Repository: redpanda-data/docs-ui
Length of output: 113
🏁 Script executed:
# Look for all GitHub workflow files
find .github/workflows -name "*.yml" -o -name "*.yaml" 2>/dev/null | sortRepository: redpanda-data/docs-ui
Length of output: 222
🏁 Script executed:
# Search for Go version pinning in workflow files
rg "go-version" .github/workflows/ -A 2 -B 2Repository: redpanda-data/docs-ui
Length of output: 1080
CI workflow version mismatch will cause build failures.
The Go version requirement has been updated to 1.26.1 in go.mod, but .github/workflows/test-bloblang-playground.yml pins Go to '1.25.x'. When the test workflow runs, the build will fail because Go 1.25.x cannot satisfy the 1.26.1 requirement.
Required fix: Update the CI workflow
Update .github/workflows/test-bloblang-playground.yml to use a compatible Go version:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.26.x' # Or use 'stable' to match other workflowsAlso update the cache key to reflect the new version:
key: ${{ runner.os }}-go-1.26.x-${{ hashFiles('**/go.sum') }}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@blobl-editor/wasm/go.mod` at line 3, go.mod requires Go 1.26.1 but the CI
workflow still pins Go to 1.25.x causing builds to fail; update the test
workflow to install Go 1.26.x (or 'stable') by changing the actions/setup-go
step's go-version to '1.26.x' and update the cache key to use go-1.26.x (e.g.,
key: ${{ runner.os }}-go-1.26.x-${{ hashFiles('**/go.sum') }}); ensure the
changes are applied in the test-bloblang-playground workflow that currently uses
actions/setup-go@v5 so CI satisfies the go.mod requirement.
vbotbuildovich
force-pushed
the
update-go-mod
branch
from
9c5f1c4 to
f9e8351
Compare
1 participant
This PR updates the Go modules for the Bloblang playground Wasm code.